Repository navigation
Conversation
Publish device visibility and the attached notification under device_list_mutex, then acquire client_list_mutex in the same order as device removal. Do not notify clients if preflight completes after the device has disappeared. Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preflight takes the client-list mutex before the device-list mutex
(
src/client.c:989-991); removal takes them in reverse order(
src/device.c:864-873). Concurrent preflight completion and disconnectcan deadlock usbmuxd.
Publish visibility and the attached event under the device lock before
taking the client lock. Skip the added event if the device has disappeared.
Validation: the original deterministic concurrency test deadlocks; the
patched add-first, remove-first, absent-device and duplicate-add cases pass.
Linux builds with preflight enabled and disabled pass with
-Werror.Assisted-by: OpenAI Codex